fix: repair failing tests and type errors across api and shared packages - #100
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#100stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- Implement paginate() utility with correct edge-case handling - Fix auth middleware HTTP method case-sensitivity (uppercase allow-list) - Add missing badRequest import in users route - Align User.username field naming between packages - Configure bun-types in tsconfig so bun:test and process resolve under tsc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and eliminates all
tsc --noEmittype errors in the api (Hono) and shared packages. Final state: 22 pass / 0 fail, tsc clean.Changes
packages/shared/src/utils/pagination.ts— Implemented thepaginate<T>()stub. Correctly handles partial last page, out-of-range pages (returns emptydata), empty arrays, andtotalPagescalculation (with a zero-sizeguard).packages/api/src/middleware/auth.ts— Fixed a case-sensitivity bug: the method allow-list used lowercase ('post') whilec.req.methodreturns uppercase ("POST"), so valid POSTs were rejected with 401. Normalised the allow-list to uppercase. No auth bypass introduced.packages/api/src/routes/users.ts— Added the missingbadRequestimport; aligned the create payload to useusername.packages/shared/src/types.ts— Made theUser.usernamefield name consistent across both packages (tests expectusername).tsconfig.json— Added"types": ["bun-types"]sobun:testand theprocessglobal resolve undertsc. No new dependencies added.Verification
bun test→ 22 pass, 0 fail (4 files)bunx tsc --noEmit→ cleanConstraints honoured
Assumptions
username/userNameinconsistency resolved towardusernamebecause the (unmodifiable) tests useusername.bun:test/processerrors were type-resolution config, not missing packages — resolved via tsconfigtypes.